potiuk commented on code in PR #59249: URL: https://github.com/apache/airflow/pull/59249#discussion_r2604524490
########## providers/edge3/docs/changelog.rst: ########## @@ -27,6 +27,9 @@ Changelog --------- +2.0.0 Review Comment: I personally think of SemVer numbers as mostly a communication tool. SemVer is really about intentions. And in this case, I believe our intention is to remove **some** functionality that we - a bit accidentally - made available to our users. Of course our users should not rally use it - it was not intended for public consumption, so technically speaking it's not really breaking because it was not intentional But because of the "auto-enabling" of AIP-44, on installing and configuring edge, even if not intended it became a feature for edge provider to work on Airlfow 2. As a users, I would be surprised not seeing it as a "breaking" change. Imagine your Bosch (yay! I got spelling right this time!) installation still running on Airlfow 2 and suddenly next version of edge3 cannot be installed - that I would say quite a problem.e We had three choices: * 1.6.1 -> this would be strange with such a drop of Airflow 2 support (again even if not intentional) * 1.7.0 -> we have not added any feature, so that would be pretty akward * 2.0.0 -> this signal significant change (and we also have warning in changelog) - some users are potentially affected So I thought that bumping major version would be a nice signal to cut off any ties with Airflow 2. That was my thinking at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
