shubham36deshpande commented on code in PR #51792: URL: https://github.com/apache/airflow/pull/51792#discussion_r2605243766
##########
chart/values.schema.json:
##########
@@ -5639,47 +5654,11 @@
},
"value": {
"type": "string"
- },
- "valueFrom": {
- "type": "object",
- "properties": {
- "configMapKeyRef": {
- "$ref":
"#/definitions/io.k8s.api.core.v1.ConfigMapKeySelector",
- "description": "Selects a key of a
ConfigMap."
- },
- "secretKeyRef": {
- "$ref":
"#/definitions/io.k8s.api.core.v1.SecretKeySelector",
- "description": "Selects a key of a
secret in the pod's namespace"
- }
- },
- "anyOf": [
- {
- "required": [
- "configMapKeyRef"
- ]
- },
- {
- "required": [
- "secretKeyRef"
- ]
- }
- ]
}
},
"required": [
- "name"
- ],
- "anyOf": [
- {
- "required": [
- "value"
- ]
- },
- {
- "required": [
- "valueFrom"
- ]
- }
+ "name",
+ "value"
Review Comment:
Sure @Miretpl , I will take a look at this and resolve them, the ci checks
and helm-test checks are resolved.
Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
