jason810496 commented on code in PR #58905:
URL: https://github.com/apache/airflow/pull/58905#discussion_r2605610539


##########
airflow-core/src/airflow/api_fastapi/execution_api/deps.py:
##########
@@ -95,3 +101,18 @@ async def __call__(  # type: ignore[override]
 
 # This checks that the UUID in the url matches the one in the token for us.
 JWTBearerTIPathDep = Depends(JWTBearer(path_param_name="task_instance_id"))
+
+
+async def get_team_name_dep(session: SessionDep, token=JWTBearerDep) -> str | 
None:

Review Comment:
   If I understand correct, we make `get_team_name_dep` as async function 
because `JWTBearerDep` is async as well. If this it the case, would it be 
better to use `AsyncSessionDep` instead of `SessionDep`? 
   
   As normal `session` seems to be blocking call, not sure will it effect the 
FastAPI async dependency injection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to