henry3260 commented on code in PR #58344:
URL: https://github.com/apache/airflow/pull/58344#discussion_r2607748348
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:
##########
@@ -257,7 +257,7 @@ def create_xcom_entry(
)
try:
- value = json.dumps(request_body.value)
+ value = XComModel.serialize_value(request_body.value)
Review Comment:
> This change shouldn't be. It was purposely done in #58900
https://github.com/apache/airflow/blob/925376664f80a2d8ca316b5579c8fe1954458265/airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py#L318-L339
It seems` xcom_new_value` was already serialized on line 318. Calling
`json.dumps()` again here causes double serialization. Is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
