jason810496 commented on code in PR #57969:
URL: https://github.com/apache/airflow/pull/57969#discussion_r2608860685


##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -250,7 +257,8 @@ def _parse_from_uri(self, uri: str):
             if self.EXTRA_KEY in query:
                 self.extra = query[self.EXTRA_KEY]
             else:
-                self.extra = json.dumps(query)
+                decoded = {k: self._maybe_json_load(v) for k, v in 
query.items()}
+                self.extra = json.dumps(decoded)

Review Comment:
   `_parse_from_uri` will only be called if we provide uri (line 170), but the 
problem described in the issue is only related to `extra` and the `uri` it 
unset.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to