This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a commit to branch v3-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit adb9a59181b9e6c7349ccd72e7d1e102737b61d2
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Thu Dec 4 16:18:38 2025 +0100
[v3-1-test] Change task log source display to hidden by default (#58749)
(#59045)
* Change task log source display to hidden by default
Update the default behavior for task log source display from shown
to hidden, providing a cleaner initial view of logs. Users can still
toggle source visibility using the settings menu
* Fix tests
(cherry picked from commit d024a46ce7d966f332e46b7f07208487b4cbdc3d)
Co-authored-by: Dheeraj Turaga <[email protected]>
---
.../ui/src/pages/TaskInstance/Logs/Logs.test.tsx | 22 ++++++++++++----------
.../ui/src/pages/TaskInstance/Logs/Logs.tsx | 2 +-
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git
a/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
b/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
index 54e82f8d604..6393bc94d71 100644
--- a/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
@@ -57,24 +57,26 @@ describe("Task log source", () => {
await waitForLogs();
let logLine = screen.getByTestId("virtualized-item-2");
- const source = logLine.querySelector('[data-key="logger"]');
- const loc = logLine.querySelector('[data-key="loc"]');
-
- expect(source).toBeVisible();
- expect(source).toHaveProperty("innerText",
"source=airflow.models.dagbag.DagBag");
- expect(loc).toBeVisible();
- expect(loc).toHaveProperty("innerText", "loc=dagbag.py:593");
+ // Source should be hidden by default
+ expect(logLine.querySelector('[data-key="logger"]')).toBeNull();
+ expect(logLine.querySelector('[data-key="loc"]')).toBeNull();
+ // Toggle source on
fireEvent.keyDown(document.activeElement ?? document.body, { code: "KeyS",
key: "S" });
fireEvent.keyPress(document.activeElement ?? document.body, { code:
"KeyS", key: "S" });
fireEvent.keyUp(document.activeElement ?? document.body, { code: "KeyS",
key: "S" });
logLine = screen.getByTestId("virtualized-item-2");
+ const source = logLine.querySelector('[data-key="logger"]');
+ const loc = logLine.querySelector('[data-key="loc"]');
- // These should now find nothing
- expect(logLine.querySelector('[data-key="logger"]')).toBeNull();
- expect(logLine.querySelector('[data-key="loc"]')).toBeNull();
+ // Source should now be visible
+ expect(source).toBeVisible();
+ expect(source).toHaveProperty("innerText",
"source=airflow.models.dagbag.DagBag");
+
+ expect(loc).toBeVisible();
+ expect(loc).toHaveProperty("innerText", "loc=dagbag.py:593");
});
});
describe("Task log grouping", () => {
diff --git a/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx
b/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx
index 8344dbefb89..f9686f106b4 100644
--- a/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx
@@ -81,7 +81,7 @@ export const Logs = () => {
"log_show_timestamp",
defaultShowTimestamp,
);
- const [showSource, setShowSource] =
useLocalStorage<boolean>("log_show_source", true);
+ const [showSource, setShowSource] =
useLocalStorage<boolean>("log_show_source", false);
const [fullscreen, setFullscreen] = useState(false);
const [expanded, setExpanded] = useState(false);