anshuksi282-ksolves commented on PR #59270:
URL: https://github.com/apache/airflow/pull/59270#issuecomment-3645188031
Thank you @bbovenzi and @pierrejeambrun for the detailed review!
I have updated the implementation based on your feedback:
1. **UI Clean-up & Tooltip:**
- Removed the text stats below the pool bar in both `PoolBarCard` and
`PoolSummary` to avoid code duplication and reduce UI clutter.
- Moved all detailed statistics (Scheduled, Deferred, Total Pools) inside
the **Tooltip**.
- Updated the i18n keys to use `common:state.*` as suggested.
2. **Logic Update (`include_deferred`):**
- Updated `PoolBar.tsx` to conditionally render "Deferred" slots in the
visual bar **only if** `include_deferred` is set to `True` for that pool.
- Added the "Include Deferred" status inside the tooltip to help users
understand the bar's composition.
I have verified the logic locally:
- **Default Pools:** Deferred slots are excluded from the bar (clean UI).
- **Configured Pools:** If `include_deferred` is enabled, the visual bar
correctly includes the deferred slots.
Ready for another look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
