potiuk commented on issue #59348: URL: https://github.com/apache/airflow/issues/59348#issuecomment-3649502054
For example auth manager could have a "isAllowed(user_id, assigned_users)" method that would be implemented by each Auth Manager. And SimpleAuthManager with "all-admin" would simply ignore assigned_users. BTW. I think current implementation (I looked at the implementation) has a small bug. If I am not mistaken, currently the whole HITLUser is compared with actual user and this comparision includes both - id and name of the user. Which is somewhat prone to error, because if the user name changes (which can happen for example when someone changes legal name - for example by marriage) it might happen that the user will lose access to their HITL workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
