choo121600 commented on code in PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#discussion_r2616803965
##########
landing-pages/site/content/en/blog/airflow-survey-2024/index.md:
##########
@@ -12,6 +12,6 @@ menu:
weight: 31
---
-
+
Review Comment:
this space is not necessary
##########
landing-pages/site/layouts/partials/navbar.html:
##########
@@ -51,7 +51,17 @@
{{ $menusLen := len .Site.Menus.main }}
<div class="navbar__links-container">
{{ range $index, $el := .Site.Menus.main }}
- {{ $active := or ($p.IsMenuCurrent "main" $el)
($p.HasMenuCurrent "main" $el) }}
+ {{ $active := false }}
+{{ with $el.Page }}
+ {{ if eq $.RelPermalink .RelPermalink }}
+ {{ $active = true }}
+ {{ else }}
+ {{ $active = or ($p.IsMenuCurrent "main" $el) ($p.HasMenuCurrent
"main" $el) }}
+ {{ end }}
+{{ else }}
+ {{ $active = or ($p.IsMenuCurrent "main" $el) ($p.HasMenuCurrent "main"
$el) }}
+{{ end }}
+
Review Comment:
I’m not convinced that this code addresses the problem you’re trying to
solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
