potiuk commented on code in PR #59399:
URL: https://github.com/apache/airflow/pull/59399#discussion_r2616941968


##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -347,6 +348,15 @@ def filter_authorized_menu_items(self, menu_items: 
list[MenuItem], *, user: T) -
         :param user: the user
         """
 
+    @abstractmethod
+    def is_allowed(self, user_id: str, assigned_users: Sequence[HITLUser]) -> 
bool:
+        """
+        Check if a user is allowed to approve/reject a HITL task.
+
+        :param user_id: the user id to check
+        :param assigned_users: list of users assigned to the task
+        """

Review Comment:
   Also that is a new functionality and some thinking on how we communicatee it 
(newsfragment) and what should be default behaviour for Auth Managers that do 
not implement it should be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to