Prab-27 commented on code in PR #59414:
URL: https://github.com/apache/airflow/pull/59414#discussion_r2618206958
##########
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:
##########
@@ -189,8 +189,7 @@ def _check_worker_liveness(self, session: Session) -> bool:
),
EdgeWorkerModel.last_update < (timezone.utcnow() -
timedelta(seconds=heartbeat_interval * 5)),
)
- .all()
- )
+ ).all()
Review Comment:
`select` works fine with` .filter()` but we can also use .`where() `-
I read this -
[here](https://docs.sqlalchemy.org/en/14/core/selectable.html#sqlalchemy.sql.expression.Select.filter)
This is just my point of view
Would love to hear your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
