choo121600 commented on issue #59402: URL: https://github.com/apache/airflow/issues/59402#issuecomment-3653928470
@Prab-27 I’ve been sending a few PRs, and out of curiosity I took a closer look at the internal logic. I think there might be one small issue worth mentioning. The current logic at lines 39–41 treats all .query() method calls as deprecated: https://github.com/apache/airflow/blob/8a109dbcb11f2edaa6255f543b0a8d37466cb439/scripts/ci/prek/prevent_deprecated_sqlalchemy_usage.py#L35-L53 This may potentially flag some legitimate API method calls used in provider code, such as those in Google or AWS providers. In those cases, .query() is not SQLAlchemy’s deprecated session.query(), but a valid .query() method defined on a different object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
