tstrilka opened a new pull request, #59467:
URL: https://github.com/apache/airflow/pull/59467

   ## Summary
   
   This PR adds a new listener hookspec `on_task_instance_skipped` that is 
called when a task raises `AirflowSkipException`.
   
   **Related issue:** closes #59370
   
   ## Motivation
   
   The current listener interface provides hooks for:
   - `on_task_instance_running` - when a task starts
   - `on_task_instance_success` - when a task succeeds
   - `on_task_instance_failed` - when a task fails
   
   But there is no hook for when a task is skipped via `AirflowSkipException`. 
This gap prevents listener implementations from handling self-skipping tasks.
   
   ## Scope & Limitations
   
   > **Important:** This hook is called **only** when a task raises 
`AirflowSkipException` during execution — i.e., when a task has actually 
started and then skips itself.
   
   This hook does **NOT** cover tasks skipped by:
   - Trigger rules (e.g., upstream failures)
   - `BranchPythonOperator` (tasks not in the selected branch)
   - `ShortCircuitOperator`
   - Manual state changes via UI/API
   - Scheduler-level decisions
   
   For comprehensive skip tracking across all skip types, use DAG-level events 
(`on_dag_run_success`/`on_dag_run_failed`) which include `AirflowStateRunFacet` 
with the complete `tasksState` map.
   
   ## Changes
   
   | File | Description |
   |------|-------------|
   | `airflow-core/src/airflow/listeners/spec/taskinstance.py` | Added 
`on_task_instance_skipped` hookspec |
   | `task-sdk/src/airflow/sdk/execution_time/task_runner.py` | Call listener 
in `finalize()` when state is SKIPPED |
   | `task-sdk/tests/task_sdk/execution_time/test_task_runner.py` | Added test 
for skipped listener |
   
   ## Follow-up
   
   OpenLineage provider implementation will be submitted in a separate PR after 
this is merged.
   
   ## Testing
   
   - Added unit test `test_task_runner_calls_listeners_skipped` that verifies 
the listener is called when a task raises `AirflowSkipException`
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to