choo121600 commented on PR #59422: URL: https://github.com/apache/airflow/pull/59422#issuecomment-3659718180
> Might be better to merge all those PRs in one: > > a) they cause conflicts when one is merged b) I think listing files individually in the hook make little sense, it would be better to do a module-bo module or at least have a number of those grouped together. I noticed that once one PR gets merged, the remaining PRs start to run into conflicts. I was initially unsure whether closing and reopening the PRs was the right approach, but I now think that might be the better option. I also agree with point (b). This wasn’t something I fully considered when I first opened the PRs, but there are quite a lot of test files, and listing them individually in the hook would make it unnecessarily long. Grouping them at least by provider or by module seems more reasonable. That said, there are already quite a few PRs open besides mine, so I’m not entirely sure what the best way forward is. What do you think about closing the PRs I opened for now, reopen them as a grouped PR for `airflow-core/tests` and separate PRs per provider, and then, once everything is merged, reorganize the hook at the module level. This way, we could also incorporate the work that other contributors have already done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
