vincbeck commented on code in PR #59399: URL: https://github.com/apache/airflow/pull/59399#discussion_r2623990630
########## airflow-core/docs/core-concepts/auth-manager/index.rst: ########## @@ -141,6 +141,7 @@ These authorization methods are: * ``is_authorized_asset_alias``: Return whether the user is authorized to access Airflow asset aliases. Some details about the asset alias can be provided (e.g. the asset alias ID). * ``is_authorized_pool``: Return whether the user is authorized to access Airflow pools. Some details about the pool can be provided (e.g. the pool name). * ``is_authorized_variable``: Return whether the user is authorized to access Airflow variables. Some details about the variable can be provided (e.g. the variable key). +* ``is_authorized_hitl_task``: Return whether the user is authorized to approve or reject a Human-in-the-loop (HITL) task. Review Comment: nit. Maybe move it at the end of the list and mention this method is optional since it has a default implementation ########## airflow-core/newsfragments/59399.feature.rst: ########## @@ -0,0 +1 @@ +Add ``is_authorized_hitl_task()`` method to fix ApprovalOperator authorization with SimpleAuthManager Review Comment: ```suggestion Add ``is_authorized_hitl_task()`` method to check whether a user a is authorized to approve a HITL task ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
