jscheffl commented on code in PR #58547:
URL: https://github.com/apache/airflow/pull/58547#discussion_r2624891958


##########
chart/newsfragments/58547.significant.rst:
##########
@@ -0,0 +1,8 @@
+Support for Multiple Celery Worker Sets in the Helm Chart
+
+Helm chart behavior related to Celery worker configuration has changed.
+Multiple worker sets can now be configured, which affects how worker sets are 
rendered and scaled.
+Users upgrading the chart should review their Helm values if they relied on 
the previous
+single worker behavior.
+
+See `Helm PR #58547 <https://github.com/apache/airflow/pull/58547>`_ for 
details.

Review Comment:
   Thanks for adding the newsfragment.
   
   Instead of pointing to the PR description can you maybe add the details to 
the RST documentation? Let's assume in 125 years the project moves away from 
Github and Microsoft is acquired by Nvidia and then Nvidia decides to tear down 
Github... then documentation would be "lost". Would be better to make the 
documentation "proper" into the Helm chart docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to