Lee-W commented on code in PR #56924:
URL: https://github.com/apache/airflow/pull/56924#discussion_r2626191136
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -281,14 +308,33 @@ def _trigger_dag_af_3(self, context, run_id,
parsed_logical_date):
)
def _trigger_dag_af_2(self, context, run_id, parsed_logical_date):
+ if self.note:
+ self.log.info("Triggered DAG with note: %s", self.note)
Review Comment:
```suggestion
self.log.info("Triggered Dag with note: %s", self.note)
```
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -264,7 +272,26 @@ def execute(self, context: Context):
)
def _trigger_dag_af_3(self, context, run_id, parsed_logical_date):
- from airflow.providers.common.compat.sdk import DagRunTriggerException
+ try:
+ from airflow.providers.common.compat.sdk import
DagRunTriggerException
+ except Exception:
+ if TYPE_CHECKING:
+ from airflow.providers.common.compat.sdk import (
+ DagRunTriggerException, # type: ignore[no-redef]
+ )
+ else:
+ DagRunTriggerException = None # type: ignore[assignment]
+
+ if self.note is not None:
+ logger = getattr(self, "log", None)
+ if logger is not None:
+ logger.info("Triggered DAG with note: %s", self.note)
Review Comment:
```suggestion
if self.note is not None:
if (logger := getattr(self, "log", None)) is not None:
logger.info("Triggered Dag with note: %s", self.note)
```
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -264,7 +272,26 @@ def execute(self, context: Context):
)
def _trigger_dag_af_3(self, context, run_id, parsed_logical_date):
- from airflow.providers.common.compat.sdk import DagRunTriggerException
+ try:
+ from airflow.providers.common.compat.sdk import
DagRunTriggerException
+ except Exception:
+ if TYPE_CHECKING:
+ from airflow.providers.common.compat.sdk import (
+ DagRunTriggerException, # type: ignore[no-redef]
+ )
+ else:
+ DagRunTriggerException = None # type: ignore[assignment]
+
+ if self.note is not None:
+ logger = getattr(self, "log", None)
+ if logger is not None:
+ logger.info("Triggered DAG with note: %s", self.note)
+
+ if DagRunTriggerException is None:
+ raise AirflowException(
Review Comment:
According to
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#dont-raise-airflowexception-directly,
we shouldn't raise AirflowException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
