Prab-27 commented on code in PR #59540:
URL: https://github.com/apache/airflow/pull/59540#discussion_r2627074838
##########
airflow-core/tests/unit/utils/test_log_handlers.py:
##########
@@ -98,8 +99,9 @@ def cleanup_tables():
class TestFileTaskLogHandler:
def clean_up(self):
with create_session() as session:
- session.query(DagRun).delete()
- session.query(TaskInstance).delete()
+ session.execute(delete(DagRun))
+ session.execute(delete(TaskInstance))
+ session.commit()
Review Comment:
Just asking
Was this added intentionally for test purposes, or by accident?
I believe the
[session-here](https://github.com/apache/airflow/blob/875a427ab3f1cc06bf470a9cebdd27aa8d9528a5/airflow-core/src/airflow/utils/session.py#L32)
will commit automatically in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
