potiuk commented on PR #59597: URL: https://github.com/apache/airflow/pull/59597#issuecomment-3670351259
Should not secret search path be passed as an initialization parameter from outside ? I think we should note have "ANY" like ANY references to core packages from shared libraries. The only references it should have is via releative imports to other shared libraries. Not even "string" form of those. Actually we might even want to extend my https://github.com/apache/airflow/pull/58825 to also check for those. In this case - an obvious solution is to have some kind of mandatory intialization method that should be called by the user and pass those paths. Then "airflow-core" could pass it's own paths, and 'task-sdk` could pass it's own - no coupling, no core nor task-sdk code in the shared library. I think we might even come up with some convention on how all "shared" libraries should be initialized by it's users - and have some common `init` pattern for all those libraries done during entrypoint and have those shared library calls generally **fail** if the `init` did not happen for them - just to be absolutely sure that we explicitly initialized those libraries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
