Prab-27 commented on code in PR #59508:
URL: https://github.com/apache/airflow/pull/59508#discussion_r2631212388
##########
airflow-core/tests/unit/dag_processing/bundles/test_dag_bundle_manager.py:
##########
@@ -250,7 +253,7 @@ def test_sync_bundles_to_db_with_template(clear_db,
session):
manager.sync_bundles_to_db()
# Check that the template and parameters were stored
- bundle_model =
session.query(DagBundleModel).filter_by(name="template-bundle").first()
+ bundle_model =
session.scalars(select(DagBundleModel).filter_by(name="template-bundle").limit(1)).first()
Review Comment:
Great explanation @henry3260 ! I really appreciate your thoughts.
I learned this concept from @pierrejeambrun , so let’s ask him what he
thinks about it.
There are a few test cases, and since we’re already applying the filters
here, so I thought about them
Let's learn more !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
