uranusjr commented on code in PR #59087:
URL: https://github.com/apache/airflow/pull/59087#discussion_r2634552453
##########
providers/standard/src/airflow/providers/standard/operators/python.py:
##########
@@ -54,11 +54,18 @@
prepare_virtualenv,
write_python_script,
)
-from airflow.providers.standard.version_compat import AIRFLOW_V_3_0_PLUS,
BaseOperator
+from airflow.providers.standard.version_compat import AIRFLOW_V_3_0_PLUS,
AIRFLOW_V_3_2_PLUS, BaseOperator
from airflow.utils import hashlib_wrapper
from airflow.utils.file import get_unique_dag_module_name
from airflow.utils.operator_helpers import KeywordParameters
+if AIRFLOW_V_3_2_PLUS:
+ from airflow.sdk.bases.decorator import is_async_callable
+ from airflow.sdk.bases.operator import BaseAsyncOperator
+
+ if TYPE_CHECKING:
+ from airflow.sdk.execution_time.callback_runner import
AsyncExecutionCallableRunner
Review Comment:
This should not be inside `if AIRFLOW_V_3_2_PLUS` (and it doesn’t work as
you expect; conditionals are always visited in type checking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
