subhash-0000 commented on PR #59507: URL: https://github.com/apache/airflow/pull/59507#issuecomment-3677371498
@pierrejeambrun Thank you for the feedback! I've implemented both of your suggestions: Reused parent's refetchInterval pattern As you suggested, I'm now passing the same refetch logic to child components based on the try instance's pending state. Both ExtraLinks and BlockingDeps receive isStatePending(tryInstance?.state) ? refetchInterval : false as a prop. This eliminated the useTaskServiceGetTask call from ExtraLinks and removed duplicate useAutoRefresh hooks. Polling now automatically stops when the try instance is no longer pending. Fixed invalid property access Removed the conditional check for taskInstance?.extra_links - you're absolutely right that this property doesn't exist on TaskInstanceResponse. The ExtraLinks component now renders unconditionally and handles its own empty state internally. The architecture is much cleaner now with a single source of truth for refresh logic in the parent component. I also applied the same pattern to BlockingDeps for consistency so it benefits from the same polling behavior. Ready for another review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
