potiuk commented on a change in pull request #6692: [AIRFLOW-6130] Make
Cassandra to GCS operator pylint compatible
URL: https://github.com/apache/airflow/pull/6692#discussion_r352285938
##########
File path: airflow/operators/cassandra_to_gcs.py
##########
@@ -247,120 +248,140 @@ def convert_value(cls, name, value):
elif isinstance(value, Time):
return str(value).split('.')[0]
elif isinstance(value, (list, SortedSet)):
- return cls.convert_array_types(name, value)
+ return cls.convert_array_types(value)
elif hasattr(value, '_fields'):
- return cls.convert_user_type(name, value)
+ return cls.convert_user_type(value)
elif isinstance(value, tuple):
- return cls.convert_tuple_type(name, value)
+ return cls.convert_tuple_type(value)
elif isinstance(value, OrderedMapSerializedKey):
- return cls.convert_map_type(name, value)
+ return cls.convert_map_type(value)
else:
- raise AirflowException('unexpected value: ' + str(value))
+ raise AirflowException('Unexpected value: ' + str(value))
@classmethod
- def convert_array_types(cls, name, value):
- return [cls.convert_value(name, nested_value) for nested_value in
value]
+ def convert_array_types(cls, value: Union[list, SortedSet]) -> List:
+ """
+ Maps convert_value over array.
+ """
+ return [cls.convert_value(nested_value) for nested_value in value]
@classmethod
- def convert_user_type(cls, name, value):
+ def convert_user_type(cls, value):
Review comment:
```suggestion
def convert_user_type(cls, value: Any) -> Dict[str, Any]:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
