choo121600 commented on PR #59643: URL: https://github.com/apache/airflow/pull/59643#issuecomment-3680919996
considered a couple of options: * Option 1: Determine whether to merge based on the existence of connection_id * Option 2: The approach implemented in this PR When testing the API, there is a scenario where users want to test the connection using a newly provided password, rather than the credential stored in the database. Considering this use case, I concluded that Option 2 handles this case more accurately than Option 1, and therefore chose Option 2. To support this, I added a `use_existing_credentials` query parameter, with the default value set to `false`. * When calling the API directly: the test is performed using the credentials provided in the request * When testing from the UI: this scenario does not occur, so the parameter is fixed to `true ` If, in the future, the UI adds functionality similar to the API test, where connections can be tested using user-provided input this parameter can be switched to`false` to support that use case in a natural and extensible way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
