uranusjr commented on code in PR #59657:
URL: https://github.com/apache/airflow/pull/59657#discussion_r2639023554
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -955,6 +956,16 @@ class ActivitySubprocess(WatchedSubprocess):
_task_end_time_monotonic: float | None = attrs.field(default=None,
init=False)
_rendered_map_index: str | None = attrs.field(default=None, init=False)
+ # Execution timeout tracking
+ _execution_timeout_seconds: float | None = attrs.field(default=None,
init=False)
+ """Task execution timeout in seconds, received from the task process."""
+
+ _task_execution_start_time: float | None = attrs.field(default=None,
init=False)
+ """Monotonic time when task execution actually started (after parsing
DAG)."""
+
+ _timeout_sigterm_sent_at: float | None = attrs.field(default=None,
init=False)
+ """Monotonic time when SIGTERM was sent due to timeout."""
Review Comment:
This brings the question if `0.0` in any of these values affects logic. You
use `is None`/`is not None` in some checks, but simple boolean checks in
others, so this is not immediately clear. This needs to be treated carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
