potiuk commented on code in PR #59726:
URL: https://github.com/apache/airflow/pull/59726#discussion_r2641006722
##########
airflow-core/pyproject.toml:
##########
@@ -85,9 +85,12 @@ dependencies = [
"cryptography>=41.0.0,<46.0.0",
"deprecated>=1.2.13",
"dill>=0.2.2",
- # limited due to changes needed
https://github.com/fastapi/fastapi/pull/14434
- # and the bug in fastapi 0.126.0
https://github.com/fastapi/fastapi/pull/14575#issuecomment-3678581316
- "fastapi[standard-no-fastapi-cloud-cli]>=0.121.0, !=0.123.5, !=0.126.0,
!=0.127.0",
+ # Limited due to backwards incompatible (but deliberate) changes in
FastAPI 0.126.0
+ # which break Cadwyn way of copying classes and break serialization. As
explained
+ # in
https://github.com/fastapi/fastapi/pull/14582#issuecomment-3682792249, Cadwyn
+ # needs to adapt to those changes and we cannot move to newer version of
FastAPI
+ # This is tracked in Cadwyn in https://github.com/zmievsa/cadwyn/issues/314
+ "fastapi[standard-no-fastapi-cloud-cli]>=0.121.0, <0.126.0",
Review Comment:
There are two main reasons:
* You do not have to look up the issues to understand why
* The reasoning and explanations in those isssues and PR might change in the
future, because assessment might change, so this one is capturing "current"
state of those issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
