johnhoran commented on code in PR #59372:
URL: https://github.com/apache/airflow/pull/59372#discussion_r2642669750
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/callbacks.py:
##########
@@ -189,12 +191,22 @@ def on_operator_resuming(
pass
@staticmethod
- def progress_callback(*, line: str, client: client_type, mode: str,
**kwargs) -> None:
+ def progress_callback(
+ *,
+ line: str,
+ client: client_type,
+ mode: str,
+ container_name: str,
Review Comment:
The method that calls this function doesn't have this as an optional
parameter, so it shouldn't be optional in the signature. The signature does
have a **kwargs param, so if an implementer doesn't include it then it will
just end up in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
