Nataneljpwd commented on code in PR #59002:
URL: https://github.com/apache/airflow/pull/59002#discussion_r2642813151
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -540,9 +540,10 @@ def consume_logs(*, since_time: DateTime | None = None) ->
tuple[DateTime | None
# a timeout is a normal thing and we ignore it and resume
following logs
if not isinstance(exc, TimeoutError):
self.log.warning(
- "Pod %s log read interrupted but container %s still
running. Logs generated in the last one second might get duplicated.",
+ "Pod %s log read interrupted but container %s still
running. Error: %s. Logs generated in the last one second might get
duplicated.",
Review Comment:
I do not think this is the best place for the error, it might make the log
unreadable, it is better to either put it in the end of the log, or as a new
log message, or just put the type, title and message of the exception instead
of the whole exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
