nhuantho opened a new pull request, #59767:
URL: https://github.com/apache/airflow/pull/59767

   ## What:
   * When I read [#53198](https://github.com/apache/airflow/issues/53198) and 
then checked the {release-name}-create-user-job, I saw that it is used only to 
create a user via the `airflow users` command ([FAB CLI 
Commands](https://airflow.apache.org/docs/apache-airflow-providers-fab/stable/cli-ref.html)).
 Therefore, I believe that `defaultUser` should not be part of the `webserver 
or apiServer`.
   * From my perspective, we should decouple the responsibilities of each 
service. Currently, `createUserJob` depends on the `webserver`, but the 
`webserver` has been replaced by the `apiServer`. As a result, we should move 
`defaultUser` to the `apiServer configuration`.
   
   ## Solution:
   * Move `defaultUser` into `createUserJob` to isolate the functionality of 
createUserJob.
   * Remove the usage of `webserver.defaultUser` from the Helm chart and 
related tests.
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to