Jayesh45-master opened a new pull request, #59768:
URL: https://github.com/apache/airflow/pull/59768
…when simple_auth_manager_all_admins=True (no one can approve/reject)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Fixes #59348
Summary
When using SimpleAuthManager with simple_auth_manager_all_admins=True,
ApprovalOperator becomes unusable if assigned_users is set.
In this configuration, no users are able to approve or reject tasks because
SimpleAuthManager does not populate a persistent user store to resolve
assigned_users.
This change detects the “all admins” mode and treats assigned_users as
effectively unrestricted, allowing any authenticated user to approve or
reject. This aligns with the intended semantics of the all-admins setup and
prevents a silent UI deadlock.
What does this change do?
Detects when SimpleAuthManager is configured with
simple_auth_manager_all_admins=True
In that mode, bypasses user-specific resolution of assigned_users
Allows any authenticated user to approve or reject tasks
Preserves existing behavior for all other authentication managers
Why is this change needed?
With simple_auth_manager_all_admins=True, all authenticated users are
implicitly administrators, but there is no backing user directory
(e.g. no ab_user table).
Attempting to resolve assigned_users against a non-existent user store
causes ApprovalOperator actions to be silently blocked in the UI.
This PR restores expected behavior without changing configuration defaults
or weakening security assumptions.
How was this change tested?
Added unit tests covering ApprovalOperator with SimpleAuthManager
and simple_auth_manager_all_admins=True
Verified approvals proceed even when assigned_users is set
Confirmed behavior remains unchanged for other auth managers
(e.g. FAB-based auth)
No regression observed for existing DAGs
Screenshots
N/A – backend authorization logic only.
Changelog
Fix ApprovalOperator behavior when using SimpleAuthManager in all-admins mode
Notes for reviewers
This is a minimal, backward-compatible fix scoped only to the all-admins
SimpleAuthManager configuration. No defaults, APIs, or security models are
changed.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
