jscheffl commented on PR #59231: URL: https://github.com/apache/airflow/pull/59231#issuecomment-3687371248
Hi @anshuksi282-ksolves! While working on latest main I realized a regression in the UI caused by inconsistent updates. Can you provide a fix? Else I'd propose to revert this PR and re-apply with a proper fix. It seems the state management and bi-directional updates are not working anymore reliably. Steps to re-produce: - Open the trigger form for the example Dag "Params UI Tutorial" - You see a required field missing, trigger button is not enabled. - Expand the "Typed parameters with Param object" - Enter at least 10 chars into the "Required text field" - Expand the "Advanced options" section and inspect the "Configuration JSON" - Attempt to trigger and see the error message, the required field is not submitted. (In general it seems no change of the form fields updates the JSON configuration in "Advanced options" section anymore and thus any change in the form yields to no effect when triggering.) Also one nit: I just realized that the "Advanced options" section is always expanded also if the form just has params defined. I understood the diff before as being a feature if a URL param is passed but now realize that the logic also hits when the UI is just opened. Oh and found another even more error situation, if you have used the dag overview page and search, e.g. Dags for name "params" <img width="486" height="189" alt="image" src="https://github.com/user-attachments/assets/6b5661e2-e59a-45fa-b284-845bbbe1de79"; /> ...then the URL is changed to something like `http://localhost:28080/dags?name_pattern=params`... which then if you trigger on the Dag overview page the form will add a parameter for the Dag search parameters from the URL into the form. So in this case parameters should / mus ONLY be parsed if called with /trigger/single and not if the page where the user navigated before contains parameters as well: <img width="333" height="267" alt="image" src="https://github.com/user-attachments/assets/766fbe2c-d5de-4add-a03a-7a9c9da4e637"; /> ...okay sorry, as of writing the bug here and ending up in three errors I'm going to revert now. Can you please re-apply the PR with fixes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
