ashb commented on a change in pull request #6696: [AIRFLOW-6128] Untangle
plugins_manager and web from cyclic dependencies. Based on [AIRFLOW-6004]
URL: https://github.com/apache/airflow/pull/6696#discussion_r352300952
##########
File path: airflow/config_templates/airflow_local_settings.py
##########
@@ -201,17 +199,17 @@
DEFAULT_LOGGING_CONFIG['handlers'].update(WASB_REMOTE_HANDLERS)
elif ELASTICSEARCH_HOST:
- ELASTICSEARCH_LOG_ID_TEMPLATE = conf.get('elasticsearch',
'LOG_ID_TEMPLATE')
- ELASTICSEARCH_END_OF_LOG_MARK = conf.get('elasticsearch',
'END_OF_LOG_MARK')
- ELASTICSEARCH_WRITE_STDOUT = conf.get('elasticsearch', 'WRITE_STDOUT')
- ELASTICSEARCH_JSON_FORMAT = conf.get('elasticsearch', 'JSON_FORMAT')
- ELASTICSEARCH_JSON_FIELDS = conf.get('elasticsearch', 'JSON_FIELDS')
+ ELASTICSEARCH_LOG_ID_TEMPLATE: str = conf.get('elasticsearch',
'LOG_ID_TEMPLATE')
+ ELASTICSEARCH_END_OF_LOG_MARK: str = conf.get('elasticsearch',
'END_OF_LOG_MARK')
+ ELASTICSEARCH_WRITE_STDOUT: str = conf.get('elasticsearch',
'WRITE_STDOUT')
+ ELASTICSEARCH_JSON_FORMAT: str = conf.get('elasticsearch',
'JSON_FORMAT')
+ ELASTICSEARCH_JSON_FIELDS: str = conf.get('elasticsearch',
'JSON_FIELDS')
- ELASTIC_REMOTE_HANDLERS = {
+ ELASTIC_REMOTE_HANDLERS: Dict[str, Dict[str, str]] = {
'task': {
'class':
'airflow.utils.log.es_task_handler.ElasticsearchTaskHandler',
'formatter': 'airflow',
- 'base_log_folder': os.path.expanduser(BASE_LOG_FOLDER),
+ 'base_log_folder': str(os.path.expanduser(BASE_LOG_FOLDER)),
Review comment:
The changes in this file seem to be just type hint related, so should be
unrelated to this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
