shahar1 commented on code in PR #53368:
URL: https://github.com/apache/airflow/pull/53368#discussion_r2644092018
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -115,7 +115,7 @@ def __init__(
completion_mode: str | None = None,
completions: int | None = None,
manual_selector: bool | None = None,
- parallelism: int | None = None,
+ parallelism: int = 1,
Review Comment:
+1 for that.
Also, I would like to revise my earlier review: setting `parallelism = 0` as
an equivalent for `parallelism = 1` seems to be confusing.
If we take `parallism = 0` meaning as-is, it means that no pods should start
at all, and I don't find it practical.
For that reason:
1. I suggest to throw an error when `parallelism < 1`.
2. If `paralelism is None` - set it to `1` and raise a `DeprecationWarning`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
