dstandish commented on code in PR #59724:
URL: https://github.com/apache/airflow/pull/59724#discussion_r2645704871
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2277,6 +2255,43 @@ def _schedule_dag_run(
return callback_to_run
+ def _update_next_dagrun_fields(
+ self,
+ *,
+ serdag: SerializedDAG,
+ dag_model: DagModel,
+ session: Session,
+ active_non_backfill_runs: int | None = None,
+ data_interval: DataInterval,
+ ):
+ """
+ Conditionally update fields next_dagrun and next_dagrun_create_after
on dag table.
+
+ The ``dag_run`` param is only to be given when
Review Comment:
that's because in writing the docstring i was like, this is dumb -- we
should not do this :) then i went ahead and pulled that param out.
basically, you were supposed to _not_ give the dag run when you created the
dag run, and you _were_ supposed to give it when you didn't (i.e. when just
making scheduling decisions). but that is confusing behavior so i pulled that
logic out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
