Dev-iL opened a new pull request, #59801:
URL: https://github.com/apache/airflow/pull/59801
### Summary
- Fix race condition causing intermittent test failures in
`TestWatchedSubprocess::test_reading_from_pipes`
- Add environment variable check to `ensure_secrets_backend_loaded()` for
test isolation across process boundaries
### Problem
The test was flaky on CI with the following error:
```none
RuntimeWarning: coroutine 'ExecutionAPISecretsBackend.aget_connection' was
never awaited
```
**Root cause**: When running tests in parallel with pytest-xdist, forked
subprocesses could inherit mocked secrets backends from other tests (via
`mock_supervisor_comms` fixture). On Python 3.13, calling `hasattr()` on an
`AsyncMock` creates an unawaited coroutine, which triggers the warning and
pollutes the captured logs assertion. The existing `use_real_secrets_backends`
fixture used `monkeypatch.setattr()`, but this only patches the parent
process—forked subprocesses don't inherit Python patches.
### Solution
Use an environment variable (`_AIRFLOW_TEST_BACKENDS_SKIP_EXECUTION_API`)
that persists across `fork()`:
1. The fixture sets the env var before the subprocess is spawned
2. `ensure_secrets_backend_loaded()` checks for this env var first and
returns only `EnvironmentVariablesBackend`, skipping
`ExecutionAPISecretsBackend`
3. This prevents the `hasattr(backend, "aget_connection")` check from being
called on mocked backends in the subprocess
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
