potiuk commented on issue #6696: [AIRFLOW-6128] Untangle plugins_manager and 
web from cyclic dependencies. Based on [AIRFLOW-6004] 
URL: https://github.com/apache/airflow/pull/6696#issuecomment-560030481
 
 
   Yeh. I actually used type-hints and mypy to verify if my changes are correct 
(except running the airflow). It is super-helpful to be confident about your 
changes while commiting them. I am using pre-commit extensively to make sure I 
do not make mistakes. It's a big value of pylint/mypy/flake that I am using.
   
   I will split out typehint changes as the last step of review. Similarly as I 
do for #6596 . But this has to come as next steps. First I use mypy/pylint to 
get my changes verified in automated way and then I can split them out to make 
sure they are change/bisect friendly.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to