Dev-iL commented on code in PR #59218:
URL: https://github.com/apache/airflow/pull/59218#discussion_r2648630938
##########
providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py:
##########
@@ -888,20 +888,26 @@ def test_get_db_manager(self, auth_manager):
@mock.patch("airflow.utils.db.drop_airflow_models")
@mock.patch("airflow.utils.db.drop_airflow_moved_tables")
@mock.patch("airflow.utils.db.initdb")
[email protected]("airflow.settings.engine.connect")
[email protected]("airflow.settings.engine")
Review Comment:
The current approach works correctly because
`mock.patch("airflow.settings.engine")` patches the module attribute that
`get_engine()` returns. The more critical issue (missing session bind dialect
mock) was already addressed in the context of a previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
