Copilot commented on code in PR #1355:
URL: https://github.com/apache/airflow-site/pull/1355#discussion_r2649267477
##########
sphinx_airflow_theme/sphinx_airflow_theme/header.html:
##########
@@ -104,6 +70,40 @@
</div>
</div>
+ <div class="navbar__theme-toggle">
+ <button class="btn btn-link nav-link dropdown-toggle d-flex
align-items-center"
+ id="bd-theme"
+ type="button"
+ aria-expanded="false"
+ data-bs-toggle="dropdown"
+ data-bs-display="static"
+ aria-label="Toggle theme (auto)">
+ <svg class="bi my-1 theme-icon-active"><use
href="#circle-half"></use></svg>
+ </button>
+ <ul class="dropdown-menu dropdown-menu-end"
aria-labelledby="bd-theme-text">
+ <li>
+ <button type="button" class="dropdown-item d-flex
align-items-center" data-bs-theme-value="light" aria-pressed="false">
+ <svg class="bi me-2 theme-icon"><use
href="#sun-fill"></use></svg>
Review Comment:
The SVG icons have inconsistent class names between the dropdown items and
the button. In the dropdown items, the class is "theme-icon" but in the theme
toggle button (line 81) it's "theme-icon-active". This inconsistency could
cause styling issues. Consider using consistent naming or documenting why they
differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
