potiuk commented on PR #59859:
URL: https://github.com/apache/airflow/pull/59859#issuecomment-3694284903

   @jscheffl, @gopidesupavan -> I created the issue in Cadwyn 
https://github.com/zmievsa/cadwyn/issues/316 , describing the issue and updated 
the exclusion from #59856 with link to the issue and `<=` rather than `!=` as 
this is really something that we will only be able to get rid after Cadwyn 
releases a new version fixing the compatibility - so it's possible new versions 
of FastAPI will be released in-between
   
   @pierrejeambrun -> I am not exactly sure about the reasoning of mocking the 
`fastapi._compat.v2.get_long_model_name` in our 
`task-sdk/dev/generate_task_sdk_models.py` - but since this method is now 
entirely removed from fastapi, and only Pydantic v2 route is going to be used, 
it's either not needed, or we'll have to do it differently. It seems it's been 
a dirty hack from the begginig anyway -> it was added here 
https://github.com/apache/airflow/pull/58524/changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to