steveahnahn commented on code in PR #59477:
URL: https://github.com/apache/airflow/pull/59477#discussion_r2649453537
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py:
##########
@@ -126,10 +126,7 @@ def validate_context(self, dag: SerializedDAG) -> dict:
end=timezone.coerce_datetime(self.data_interval_end),
)
else:
- data_interval = dag.timetable.infer_manual_data_interval(
- run_after=coerced_logical_date or
timezone.coerce_datetime(run_after)
- )
- run_after = data_interval.end
+ data_interval =
dag.timetable.infer_manual_data_interval(run_after=coerced_logical_date)
Review Comment:
We are under ```if coerced_logical_date:``` conditional, therefore
```coerced_logical_date``` is guaranteed to exist so I removed the remaining
dead code from the or statement and cleaned up the variable assignment. The
actual fix is removing run_after = data_interval.end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
