potiuk commented on code in PR #59823:
URL: https://github.com/apache/airflow/pull/59823#discussion_r2649580074
##########
airflow-core/tests/unit/jobs/test_scheduler_job.py:
##########
@@ -3486,7 +3492,9 @@ def my_task(): ...
self.job_runner._do_scheduling(session)
assert (
- session.query(DagRun).filter(DagRun.dag_id == dr.dag_id,
DagRun.run_id == dr.run_id).one().state
+ session.scalars(select(DagRun).where(DagRun.dag_id == dr.dag_id,
DagRun.run_id == dr.run_id))
+ .one()
+ .state
Review Comment:
Those are the most important part of contribution - to have conversation and
learn from each other :)
##########
airflow-core/tests/unit/jobs/test_scheduler_job.py:
##########
@@ -3486,7 +3492,9 @@ def my_task(): ...
self.job_runner._do_scheduling(session)
assert (
- session.query(DagRun).filter(DagRun.dag_id == dr.dag_id,
DagRun.run_id == dr.run_id).one().state
+ session.scalars(select(DagRun).where(DagRun.dag_id == dr.dag_id,
DagRun.run_id == dr.run_id))
+ .one()
+ .state
Review Comment:
Those are the most important parts of contribution - to have conversation
and learn from each other :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
