Srabasti commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649630871
##########
airflow-core/.pre-commit-config.yaml:
##########
@@ -419,3 +419,12 @@ repos:
^src/airflow/serialization/serialized_objects\.py$
pass_filenames: false
require_serial: true
+ - id: prevent-deprecated-sqlalchemy-usage
+ name: Prevent deprecated sqlalchemy usage
+ entry: ./scripts/ci/prek/prevent_deprecated_sqlalchemy_usage.py
+ language: python
+ files: >
+ (?x)
+ ^airflow-ctl.*\.py$|
+ ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-ctl/tests/.*\.py$|
Review Comment:
Good catch @Prab-27 ! Reverted the change and pushed again.
Found the same file here hence thought both places need to be changed.
I was working on test_processor.py file and it got picked up by someone else
before I could raise draft PR, hence it still shows up here from the old
branch. Looks like the changes did not go through for the new branch yet.
Update in progress now.
Quick question - Is there a specific reason as to why the same file
".pre-commit-config.yaml" exists in multiple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
