roykoand commented on code in PR #59869:
URL: https://github.com/apache/airflow/pull/59869#discussion_r2649958628
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -319,10 +322,17 @@ def _create_cluster(
kubeconfig_file = get_kubeconfig_file(python=python,
kubernetes_version=kubernetes_version)
(KUBERNETES_TEST_PATH /
".env").write_text(f"KUBECONFIG={quote(kubeconfig_file.as_posix())}\n")
get_console(output=output).print(f"[success]KinD cluster
{cluster_name} created!\n")
- get_console(output=output).print(
- "\n[warning]NEXT STEP:[/][info] You might now configure your
cluster by:\n"
- )
- get_console(output=output).print("\nbreeze k8s
configure-cluster\n")
+
+ if show_hints:
+ get_console(output=output).print(
+ "\n[warning]NEXT STEP:[/][info] You might now configure
your cluster by:\n"
Review Comment:
I know this comes from previously written code, but the wording feels a bit
odd. Maybe “You can now” or “You may now” would be a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
