zach-overflow commented on code in PR #59239: URL: https://github.com/apache/airflow/pull/59239#discussion_r2651134068
########## providers/amazon/tests/unit/amazon/aws/operators/test_ecs.py: ########## Review Comment: Oh, good question: These changes were needed in order to pass the mypy provider checks. [This thread](https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1766141705921339?thread_ts=1766098339.724779&cid=CQ9QHSFQX) in the Apache Airflow Slack has some very helpful context from `@potiuk`. If I'm understanding the details in that thread, and the links therein, mypy provider checks were failing due to mypy detecting changes which surfaced some pre-existing type ambiguity. E.g, from the [contributor docs on mypy](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#mypy-checks): > However, in some cases, it produces different results than when running checks for the whole set of files, because mypy does not even know that some types are defined in other files and it might not be able to follow imports properly if they are dynamic I'll make sure to note this in the PR description as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
