justinpakzad commented on code in PR #59874:
URL: https://github.com/apache/airflow/pull/59874#discussion_r2651514471
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -424,14 +424,27 @@ def delete_xcom(
key: Annotated[str, Path(min_length=1)],
map_index: Annotated[int, Query()] = -1,
):
- """Delete a single XCom Value."""
+ """
+ Delete XCom entry(ies).
+
+ This endpoint allows specifying `~` as the task_id or key to enable bulk
deletion.
Review Comment:
Got it. I updated the endpoint to take those args as optional query params
and removed the '~' logic completely. The only issue I ran into was that the
current `has_xcom_access()` dependency (which is not currently implemented) is
applied to the router and wouldn't be compatible with the new version of delete
endpoint. I moved it to individual endpoints for now and excluded it from
delete. Not sure if that's the best approach but given it's not even
implemented I thought it made sense. Curious to hear your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
