potiuk commented on code in PR #59921:
URL: https://github.com/apache/airflow/pull/59921#discussion_r2652901240
##########
providers/openlineage/src/airflow/providers/openlineage/sqlparser.py:
##########
@@ -497,6 +498,14 @@ def get_openlineage_facets_with_sql(
try:
sqlalchemy_engine = hook.get_sqlalchemy_engine()
+ except ImportError as e:
+ if "sqlalchemy" in str(e).lower() or "No module named 'sqlalchemy" in
str(e):
+ raise AirflowOptionalProviderFeatureException(
Review Comment:
I think here we should not raise the exception, but we should raise warning,
I think this method should work fine without sqlalchemy - if it can get
information from sql_parser (which also does not need sqlalchemy ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
