potiuk commented on code in PR #59885:
URL: https://github.com/apache/airflow/pull/59885#discussion_r2652938098
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -1189,7 +1189,7 @@ def _deploy_helm_chart(
"--kube-context",
kubectl_context,
"--timeout",
- "10m0s",
+ "20m0s",
Review Comment:
Seriously - Yeah. I think Go Duration parser would work without it, but all
examples have `xm0s` when there is no hour - in all the docs I looked at.
I guess it's a bit of a convention to not confuse it with Month, even if in
Go "M" is the format for Month.
I saw both "5m0s" and "1h45m" in docs -> both are obvious, where "5m" could
be easily understood as 5 months for untrained eye.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
