trina242 opened a new pull request, #59953:
URL: https://github.com/apache/airflow/pull/59953
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related: #59349
This PR is yet another attempt to get rid of
`sqlalchemy.exc.PendingRollbackError` in FAB provider caused by duplicated
sessions. I believe previously applied fixes #57815 and #58196 were a way to
go, although an important change - using `scoped_session` instead of `Session`
- was overridden later by #58644.
I decided to use `scoped_session` directly in `AirflowAppBuilder` as it's
safe to use both inside and outside the application due to [implicit method
access](https://docs.sqlalchemy.org/en/20/orm/contextual.html#implicit-method-access)
and it simplifies otherwise messy type annotations.
First contribution, please be nice 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
