Re: [PR] feat : E2E test for Create backfill with all reprocess behaviour [airflow]

[via GitHub]

vatsrahul1001 commented on PR #59633:
URL: https://github.com/apache/airflow/pull/59633#issuecomment-3701424010

   @i
   
   > > @iharsh02 Looks like tests from the previous PR #59791 are failing for 
first try and passed on retry
   > > ```
   > > * should verify backfills list display
   > > 
   > > * Verify backfill details display
   > > 
   > > * should verify Table filters
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > <img alt="image" width="1100" height="325" 
src="https://private-user-images.githubusercontent.com/43964496/531011395-091b79a6-48dd-4b68-8430-ff63ef5c5731.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjcxMTE2NDIsIm5iZiI6MTc2NzExMTM0MiwicGF0aCI6Ii80Mzk2NDQ5Ni81MzEwMTEzOTUtMDkxYjc5YTYtNDhkZC00YjY4LTg0MzAtZmY2M2VmNWM1NzMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjMwVDE2MTU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFhNTk0ZmE1YTlkNTJlMzFkOWE2YTdmOTNhODAwYjE4Zjc0ZDVkNTI1MDJhNDgwNDhiZWY5NzI1ZDIzN2YzYjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.UcDptVI_HOFa5DhcNc-6iGWxXpqzNGHBT1cUFxn5q0U";>
   > > Test from #59791 (Backfills List Display) uses date range getPastDate(2) 
→ getPastDate(1) (2-1 days ago) and #59633 (Create Backfill) | "All Runs" test 
use same date range getPastDate(2) → getPastDate(1) (2-1 days ago) So as 
backfills for same details already in progress we are getting "No runs 
matching" and due to this backfill button is disable and test fails on first try
   > > Quick fix should be to use different dates for the "All Runs" test.
   > 
   > Yeah I am using different date for each test , just need to change the 
date for the `"Should create backfill with 'all runs' behavior"`
   > 
   > For `Backfills List Disaply` test we are using beforeAll hook so we only 
creating 1 Backfill and verify for the all the test under it
   
   
   
   
   > please share the test trace , test passing locally
   
   @iharsh02, you can also check the test results in 
[CI](https://github.com/apache/airflow/actions/runs/20605043241/job/59180324147?pr=59633).
 The issue is backfill run from the previous merged PR is interfering with the 
backfill runs of this PR test. When a backfill is already in progress, creating 
a new one might be blocked or queued.
   
   Before creating any new backfill, we should check that there is no backfill 
in progress already. Check if we can do like this.
   
   ```
   async waitForNoActiveBackfill() {
     const backfillInProgress = this.page.locator('text="Backfill in 
progress:"');
     await backfillInProgress.waitFor({ state: "hidden", timeout: 120_000 });
   }
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org