chsanjeev commented on PR #59813: URL: https://github.com/apache/airflow/pull/59813#issuecomment-3701491063
I was the one who reported this issue initially, so wanted to chip in before this goes to main. I suspect that bumping it up to 1000 may still cause issues in the future as the external executor ids are managed by the external executors. My thoughts are to make it as a TEXT field or some 10_000 for two reasons; 1. I dont see that this column is used for any joins or used as referential/primary key, so making it text has no implication on the metadata querying performance. 2. If we limit the conversation just to AWS lambda executor, there are high chances that the external id set by the executor will be more than 1000 chars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
